dtr-org / unit-e

A digital currency for a new era of decentralized trust
https://unit-e.io
MIT License
45 stars 15 forks source link

Mute false errors during full sync #990

Closed frolosofsky closed 5 years ago

frolosofsky commented 5 years ago

When full sync, commits are usually far ahead of the current active chain tip, but at the same time, vote recorder records votes against the current active chain tip which leads to false positive error messages in the log.

Note: avoiding of these messages could be reached by passing CBlockIndex->pprev finalization state to VoteRecorder instead of the active chain's tip one. But we're still debating on this topic because beside logging this change would have a security impact. Muting false errors is a compromise we can use unless we decide the good strategy for finalization state picking.

Fixes #988.