search

dtrenz / LaunchGate

LaunchGate makes it easy to let users know when an update to your app is available.
http://dtrenz.github.io/LaunchGate
Other
60 stars 16 forks source link

optionalUpdate is ignored if requiredUpdate is present #30

Open kc8nod opened 7 years ago

kc8nod commented 7 years ago

If "requiredUpdate" is present in the JSON, then "optionalUpdate" is ignored. Likewise if "optionalUpdate" is present, then "alert" is ignored.

RLRG commented 7 years ago

Hi @kc8nod ,

I have been checking the operation of the framework and it makes sense that the optionalUpdate is ignored if requiredUpdate is present, it is how Gandalf (Android equivalent) works too.

There is a slight difference in the operation comparing to Gandalf: the alert has more priority over the optionalUpdate in Gandalf and in the LaunchGate it is just the opposite.

Gandalf (Android) logic:

screen shot 2017-09-27 at 16 17 01

Current LaunchGate (iOS) logic: screen shot 2017-09-27 at 16 17 11

I'll create a new issue to change the iOS behaviour to be the same to the Android one (#35).

Please, @dtrenz , can you check if what I state here makes sense to you? If so, you can close this issue in my opinion.

Thanks a lot !

Rodrigo

kc8nod commented 7 years ago

Imagine the case where requiredUpdate is 2.0 and optionalUpdate is 4.0

Now suppose that a user is running version 3.0. That user will never see the prompt to upgrade to 4.0

RLRG commented 7 years ago

Hi again @kc8nod ,

Yes, you are right; but I have been testing with the exampleApp included in the project and this issue is also fixed with the Pull Request #36 which fixes also the issue #35 so that it can also be closed. I mean: the example you provide with your comment works as expected, i.e., the user sees the prompt to upgrade to 4.0. You can test it also and if you find any inconsistency in the operation, you can open a new issue.

Thanks for the notice anyway ;) Let's wait for @dtrenz confirmation about all of this we are discussing.

Best regards,

Rodrigo