README file give bad pom.xml example

dtrott / maven-thrift-plugin

Maven Thrift Plugin that executes the thrift code generator (base on protocol buffers plugin)

120 stars 68 forks source link

README file give bad pom.xml example #10

Closed lvjp closed 13 years ago

lvjp commented 13 years ago

What user can expect:

mvn generate-sources generate the sources for the main folder
mvn generate-test-sources generate the sources for the test folder

What it should be writted:

<executions>
    <execution>
        <phase>generate-sources</phase>
        <goals>
            <goal>compile</goal>
        </goals>
    </execution>
    <execution>
        <phase>generate-test-sources</phase>
        <goals>
            <goal>testCompile</goal>
        </goals>
    </execution>
</executions>

dtrott commented 13 years ago

It is also necessary to set the id attribute I have made the change to the README

Thanks.