search

dtrott / maven-thrift-plugin

Maven Thrift Plugin that executes the thrift code generator (base on protocol buffers plugin)
120 stars 68 forks source link

Version 0.1.11+ breaks Thrift 0.5.0 compatibility #12

Closed andrewclegg closed 12 years ago

andrewclegg commented 12 years ago

The buildThriftCommand method in Thrift.java generates a -out param which isn't recognised. In earlier versions of Thrift -- well, 0.5.0 which is the only one I've tried -- this should be -o.

Feel free to mark as WONTFIX if backwards compat. isn't a goal :-)

dtrott commented 12 years ago

Per the readme:

CAUTION: Plugin version 0.1.11 requires thrift compiler version 0.7.0 or newer. You must use plugin version 0.1.10 for older thrift versions.

0.1.10 should work fine, however I don't intend to continue to support older thrift versions.

andrewclegg commented 12 years ago

Sorry, I completely overlooked that!