dtrott / maven-thrift-plugin

Maven Thrift Plugin that executes the thrift code generator (base on protocol buffers plugin)
120 stars 68 forks source link

Some minor optimize #22

Closed vongosling closed 10 years ago

vongosling commented 10 years ago
  1. Add .gitignore file to ignore some unexpected commit file list
  2. Remove getOutputDirectory method ,so as to utilize last local variant outputDirectory
  3. Remove some warnings in eclipse(remove useless warning suppress)
  4. Modify default thrift'idl root directory to be compliant with maven default directory guide
vongosling commented 10 years ago

This maven plugin is good job,How can i become a code contributor

vongosling commented 10 years ago

oh.I think of I modified Thrift class default visibility to public ,because someone may invoke it in the project code directly~

vongosling commented 10 years ago

@dtrott Can you check this request

dtrott commented 10 years ago

No value add.