libthrift isn't actually needed

dtrott / maven-thrift-plugin

Maven Thrift Plugin that executes the thrift code generator (base on protocol buffers plugin)

119 stars 68 forks source link

libthrift isn't actually needed #4

Closed kimballa closed 13 years ago

kimballa commented 13 years ago

Since the plugin just calls the thrift executable, it doesn't need to declare a dependency on libthrift in the pom. Doing so actually prevents this plugin from being used with (for example) libthrift 0.5.0, the latest release.

dtrott commented 13 years ago

The libthrift dependency was incorrectly declared it should have been at test scope. However since there are currently no tests that require it I have simply pulled your commit.

I will re-add (a current version) at test scope when necessary.