search

dtrungtin / actor-airbnb-scraper

Airbnb Scraper actor is designed to extract most of publicly available data for home listings
https://apify.com/dtrungtin/airbnb-scraper
27 stars 22 forks source link

process.exit(0) should not be used #29

Closed pocesar closed 3 years ago

pocesar commented 3 years ago

process.exit(0) will skip the statistics and writing settling RequestQueue handled request that can lead to unexpected behavior if the scraper is resurrected. https://github.com/dtrungtin/actor-airbnb-scraper/commit/5553c358bb1eb3e96db195db3d985adefbd26ebc#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556R296

please keep the await autoscaledPool.abort(), as it's now under crawler.autoscaledPool

zpelechova commented 3 years ago

@pocesar Could you please briefly check if I can close this one?

pocesar commented 3 years ago

@zpelechova yes, it's fixed

zpelechova commented 3 years ago

fixed 07/21