search

dtrungtin / actor-airbnb-scraper

Airbnb Scraper actor is designed to extract most of publicly available data for home listings
https://apify.com/dtrungtin/airbnb-scraper
27 stars 22 forks source link

Fix/occupancy #40

Closed lhotanok closed 2 years ago

lhotanok commented 2 years ago

Fixes #26 Add support for localized startUrls (such as https://www.airbnb.cz/rooms/37288141)

lhotanok commented 2 years ago

I'm thinking if there is a way to make these PRs smaller? E.g. first do only refactor and then only fix or vice versa? I know that they go hand in hand and it is hard to fix without refactor or refactor broken code. But at some point we will need to make the review process smoother. Let's think about it :)

Otherwise, let's merge and do after review maybe by @pocesar :)

@metalwarrior665 Yeah, I've been thinking about it as well 😅 This way I often get comments on code I didn't write myself and that was just moved to a different function. But at least I learn something new. So for bigger issues, I'll try 2 PRs approach if refactoring is needed. Refactoring-first might work better, I don't like to add more code to the existing long code chain where you can barely follow variable scopes 😄

There could be potential issues with merge conflicts though. To make 2 PRs at the same moment, you need to have 2 different branches, right? So we would need to synchronize the PRs, merge them in the right order and if there was some other PR merged in the meantime, merge conflicts would have to be resolved in both branches.