Brew formula for using on a Mac

dtrx-py / dtrx

Do The Right Extraction

GNU General Public License v3.0

224 stars 10 forks source link

Brew formula for using on a Mac #20

Closed cipri-tom closed 2 years ago

cipri-tom commented 2 years ago

Hi !

Many thanks for the port ! I almost went away from dtrx, considering it abandonware, but thanks to you it still lives ! 👏

Would you consider also hosting a small formula that would allow mac users to install it using brew ? It could be as simple as this (old) one: https://github.com/xhochy/homebrew/blob/master/Library/Formula/dtrx.rb

Many thanks, already, for the great work !

noahp commented 2 years ago

Oh wow, thank you! I'll look into adding a brew formula, thanks for the suggestion!

noahp commented 2 years ago

Just leaving some notes for myself:

dtrx formula was removed here due to dep on unrar: https://github.com/Homebrew/homebrew-core/pull/66609/commits/0a94a41668d224ac51393b1c97d73ad635daf91a can probably copy that and update it
they also link to here: https://docs.brew.sh/Acceptable-Formulae so double check that before pr'ing

Interestingly, https://brettcsmith.org/2007/dtrx/ now redirects to this github repo!

cipri-tom commented 2 years ago

Hi Noah !

Just a small nudge that this would still be a great thing to have ^^ (found myself needing it again). I'd consider making it, but it's best if you're the author, in case there are updates later on

noahp commented 2 years ago

:sweat_smile: thank you for the reminder! posted a PR now for it :crossed_fingers:

noahp commented 2 years ago

Ok, looks like the brew formula has been merged! Let me know if there's any issues (reopen this one or a new one 👍), and thanks pointing me at this!

cipri-tom commented 2 years ago

works like a charm ! Thanks a lot !