Gentler exit on missing 'file' command

dtrx-py / dtrx

Do The Right Extraction

GNU General Public License v3.0

224 stars 10 forks source link

Gentler exit on missing 'file' command #25

Closed noahp closed 2 years ago

noahp commented 2 years ago

dtrx exits quite abruptly with a traceback if the file command is not present on the host (for example, on the docker image python:3.10-slim-buster).

Add a fix to more gently exit with a message on this event:

dtrx: ERROR: 'file' command not found, skipping magic test

Add a pretty janky test to ensure it stays fixed.

Fixes #24

ChrisJefferson commented 2 years ago

nice use of docker for testing, I'll remember that for future :)