search

dtrx-py / dtrx

Do The Right Extraction
GNU General Public License v3.0
224 stars 10 forks source link

dtrx gets stuck sometimes #29

Open an-schall opened 2 years ago

an-schall commented 2 years ago

We are using dtrx to uncompress various files in a given directory. We noticed however that quite often dtrx gets stuck on some file (or even file types). I could not find a pattern here but we often see this with ISO files.

Could you check whether dtrx can be improved in a way to exit clean even if a file (file type) is provided that dtrx cannot work with?

Thanks, André

noahp commented 2 years ago

Thanks for reporting this! If you could provide an example archive that would be very helpful- or if you have a backtrace or error output with the file type?

an-schall commented 2 years ago

Hi there,

we are calling dtrx from within a script, which basically passes any file from within a directory to dtrx inside a for loop.

Inside the for loop dtrx itself is called via:

dtrx -rn "$file"

I identified a couple of files that makes dtrx stuck. I copied those files into a temporary directory and executed dtrx on these files manually with the verbose switch enabled but nothing happens and dtrx gets stuck again.

I would like to share those files with you. However, they may resemble intellectual property. Is there a way that that I could share the files with you in a discrete way (i.e. a password-protected archive and I send you the password via an out-of-bound channel)?

Thanks, André

an-schall commented 2 years ago

I created a zip file containing sample files that keeps dtrx stuck:

https://we.tl/t-NxvugfRoOq

noahp commented 2 years ago

Thank you, very helpful! I should be able to make a fix for those issues.

an-schall commented 2 years ago

Hi there,

just a quick question: Were you able to identify the underlying issue why some input files make dtrx stuck?

Thanks, André

noahp commented 2 years ago

Thanks, I was! There were duplicate file entries in the sample archive. Working on a patch to handle that, see #34

an-schall commented 2 years ago

Awesome! Much appreciated. Your support on this project is among the best I have seen since a long time. Keep up the good work.

an-schall commented 2 years ago

Hi there,

can you already anticipate when there will be a patch for the issue at hand?

Thanks!

an-schall commented 1 year ago

Hi noahp,

any news on this? Patching this would improve our processes dramatically.

Best, André