Non-interactive mode: Skip password input requests

dtrx-py / dtrx

Do The Right Extraction

GNU General Public License v3.0

230 stars 10 forks source link

Non-interactive mode: Skip password input requests #32

Open an-schall opened 2 years ago

an-schall commented 2 years ago

Hi there,

for the non-interactive mode, it would be useful to automatically skip asking for password inputs on password protected files.

Best, André

noahp commented 2 years ago

Agreed- do you think we should:

error and abort if a password-protected archive is detected?
skip but print a warning?

an-schall commented 2 years ago

If the non-interactive mode is given I believe skipping the file and printing a warning is the way to go.

ChrisJefferson commented 1 year ago

Just diving into this (very old) issue, this seems to work fine -- one of the tests checks dtrx -n test-pw.zip and makes sure it errors out. However, that code is I think older than your PR, so maybe you have a passworded file which is causing problems?