search

dtrx-py / dtrx

Do The Right Extraction
GNU General Public License v3.0
224 stars 10 forks source link

Send stdout to /dev/null unless it is needed #43

Closed ChrisJefferson closed 1 year ago

ChrisJefferson commented 1 year ago

'unrar' produces lots of output to stdout, and previously this output was stored in a pipe with Subprocess.PIPE, which could get filled up, causing everything to hang.

Almost all the of the time we do not care what uncompressors are producing on stdout, so just send it to /dev/null. Add a way of stopping this behaviour for the one uncompressor which currently does read the output pipe.

ChrisJefferson commented 1 year ago

Fixes #42

petoor commented 1 year ago

hi @noahp.

I need this PR. Would you be kind as to either accept it or reject it?

petoor commented 1 year ago

@noahp any chance you could accept / reject this?

noahp commented 1 year ago

@petoor apologies, just seeing this, thank you for the notification! Merging now.

noahp commented 1 year ago

Published this in 8.5.3.

petoor commented 1 year ago

Cheers!