search

dtsivkovski / PMB-Portfolio

Tri 1: Python and Flask Intro
1 stars 2 forks source link

Week 7 Review #33

Open dtsivkovski opened 3 years ago

dtsivkovski commented 3 years ago

Week 7 Review

See our week 7 review README for our code and videos

dtsivkovski commented 3 years ago

Mr. M says 1.75/2, lacking secondary thinking

AD1616 commented 3 years ago

TEAM Video Every member talked for around 30 seconds and showed runtime. It might be good for all teammates to show commits as only one did. ReadME/Scrum Board Specify the commits for each task rather than showing all of the individual’s commits. 3 Good things We liked how in the color codes page the background color changed with the inputs. Link to this code: https://github.com/dtsivkovski/PMB-Portfolio/blob/main/templates/minilabs/colorcodes.html The unsigned addition page was done well, and we especially liked the “Toggle operators” button. Link to Timmy’s commit for this: https://github.com/dtsivkovski/PMB-Portfolio/commit/e30c6d88f11abb9b028683384775880d38410b53 Binary shifting was also intuitive. Link to code on the binary page: https://github.com/dtsivkovski/PMB-Portfolio/blob/main/templates/minilabs/binary.html One thing that needs improvement: Logic Gates Link to the logic gates: https://github.com/dtsivkovski/PMB-Portfolio/blob/main/templates/minilabs/logicgates.html Very similar to someone’s (Anthony) code. Switch the formatting of the logic gates. Team points: 5.75/6

INDIVIDUAL

Armaan: 1.75/2 Finished the quizzes and notes for 3.5 and 3.6, shown on journal. His journal is linked here. Worked on logic gates, but the commit did not seem like a lot of work compared to other team members. Very basic design for code. Chris: 2/2 Finished the quizzes and notes for 3.5 and 3.6, shown on journal. His journal is linked here. Worked on signed addition, commit shows significant work done. While committed by Daniel, Chris explained he could not commit on his computer which was a problem he talked to Mr. Mortensen about. Daniel: 2/2 Finished the quizzes and notes for 3.5 and 3.6, shown on journal. His journal is linked here. Completed 3 tasks: shift, unicode, and color codes. Doing a lot more work than others on the team. Timothy: 2/2 Finished the quizzes and notes for 3.5 and 3.6, shown on journal. His journal is linked here. Worked on unsigned addition, commit shows significant work done.

Total scores for each individual: Armaan: 7.5/8 Chris: 7.75/8 Daniel: 7.75/8 Timothy: 7.75/8

jm1021 commented 3 years ago

I am concerned as I look at this as several things seem to be very familiar. The signed addition is wrong and same as Daniel Levy team. The Logic Gates is a very early addition from Anthony that I don't think is a very good UI. The unsigned looks identical to another group. The stuff that Daniel shared looks more unique and he explains it well.

Daniel will keep score.
Tim and Chris will be a 7.2 of 8. They need to correct behavior on commits. Also, there are instances of their visuals almost identical in classroom. Arman needs to do some mods to his code to receive 6.8.