dtsong / sleeper-api-wrapper

A Python API wrapper for Sleeper's API: https://docs.sleeper.app/
MIT License
61 stars 21 forks source link

Improve package meta (documentation, typing, etc) #14

Open wfordh opened 1 year ago

wfordh commented 1 year ago

I think it'd be worthwhile to get the package polished up to help it stand out on pypi and make it easier to use, mainly with things like documentation, typing, testing, and linting. I was inspired by this blog post on Tubthumper, another open source repo. I wanted to open this issue to start the high level discussion on these potential additions, but am happy to split it out.

I'm by no means an expert here and it would be my first time figure out a bunch of these things, but think it'd be pretty cool. I might have some time in the next couple months to work on it, too. LMK your thoughts @dtsong

dtsong commented 1 year ago

@wfordh, likewise it would be my first time figuring some of this out too. Good call on raising these in a high level issue for the discussion. I'll split a couple issues out to allow for focused discussion on the raised topics!

wfordh commented 1 year ago

Sounds good, guess we can figure it out together! Another thing that's less high level that I think would be good is adding a __repr__() (or is it __str__() that we'd want?) method to each class to make printing the objects easier. I think I'll have time over the next few weeks to work on things. Happy to prioritize these things however it makes sense.

It also might be overkill, but we could start up a Discord server or something to make communication easier.

wfordh commented 1 year ago

Discord server https://discord.gg/NaX8GQkJ

dtsong commented 1 year ago

Sure let's do that, @wfordh !

dtsong commented 1 year ago

@wfordh , feel free to email me a link to join, think the above link is expired.