dttrugman / GrowClust3D.jl

Julia-based implementation of GrowClust relative earthquake relocation.
GNU General Public License v3.0
46 stars 7 forks source link

find_moho fails for fine-grained velocity models #5

Closed yetinam closed 8 months ago

yetinam commented 8 months ago

Hi @dttrugman , I've run into an issue with the find_moho function defined here: https://github.com/dttrugman/GrowClust3D.jl/blob/47743b8a4f1cbb7d792e039eb36350dd583b2711/src/seismotrace.jl#L62-L79 The problem occurs when inputting a fine-grained velocity model that does not have any jumps larger than dalphaM. In this case the function calling find_moho in traveltime.jl will crash. As the parameter dalphaM is not accessible here, this crash can not be avoided with configuration parameters.

Potential solutions that come to my mind are:

dttrugman commented 8 months ago

Thanks for pointing this out. Should be fixed now, using a combination of bullet points (1) and (3) above.

Daniel

yetinam commented 8 months ago

Thanks for the quick fix!