search

dtudk / pythonsupport-page

Site for the documentation of the Python support's homepage
https://pythonsupport.dtu.dk
BSD 3-Clause "New" or "Revised" License
2 stars 13 forks source link

Added scuffed scraper tool. #16

Closed so-rose closed 1 year ago

so-rose commented 1 year ago

Should all work according to the README.

Also see README for instructions on how to use the TOML output.

so-rose commented 1 year ago

.gitignore

Again, sure? Someone, someday, might check in the cache folders; these contain 1440 * 2 20KB files, and 1440 additional TOML files. The repo bloat isn't horrible, but it can easily add ~70MB, and extracting these out of the history of a public repo is never, ever fun. A harmless local .gitignore is an effective guard against that.

License

Considering the base (AGPL) was made months ago, and that it is itself a derivative work of "DTU Course Analyzer" (https://github.com/SMKIDRaadet/dtu-course-analyzer, also AGPL), mustn't this scraper as a whole (including parts written at work) also be AGPL? The scraping approach with BeautifulSoup, including several lines that find some important tags, come directly from the original "DTU Course Analyzer" - both the old and newly written portions do this.

The LICENSE file here helps make users aware of the licensing distinction from pythonsupport-page, in combination with the header on the file. I do see the copyrights in the header and/or a dedicated CONTRIBUTORS file maybe needing to include the "DTU Course Analyzer contributors" (and, depending on the exact terms of my employment in the forthcoming contract, possibly DTU as well).

(For the record, there's no "viral" concern when a separate project is included like this in a tools/ directory)

zerothi commented 1 year ago

I would still leave out the .gitignore. Please.

As for the license. I wasn't aware of you copying it from that place. As a whole the things we do are DTU paid, hence DTU owned/copyrighted. Lets keep it then. Great!

so-rose commented 1 year ago

Did the things, should be good to go. Let me know if I should change anything else.