dturevski / olive-gui

Olive is a free open source cross-platform graphical front-end for Popeye chess software and more.
GNU General Public License v3.0
14 stars 5 forks source link

roles for versioners and afterees #50

Open andrew-buchanan opened 2 years ago

andrew-buchanan commented 2 years ago

Thanks for all your work!

Please add roles for versioner/corrector and afteree, please, so that name is checked on entry against controlled list of authors rather than being put in an uncontrolled comment field. Also will be able to search properly on these, rather than guessing language and transliterated spelling.

Thanks again, Andrew

andrew-buchanan commented 2 years ago

Hi,

I posted https://github.com/dturevski/olive-gui/issues/50 three weeks ago on this subject, but there's no response here. So I will repeat in yacpdb email thread.

If A corrects a problem by B or makes a new version, then one option for B is to declare that the problem is "B, correction/version A". B remains the composer, however it's not reasonable to just stick A's name in a comment field. The corrector or versioner is always another composer, so there should be the same data checking and search facilities available for a corrector, versioner (or afteree!) as there is for the composer. We have multiple alphabets, languages, spellings and assumed names, so throwing a name in a comment field is basically throwing it away.

As someone who spends a lot of time tracking the history of problems, and sometimes fixing them, this issue is the deal-breaker for me with the otherwise wonderful yacpdb database.

I hadn't seen the problemXML stuff before. It's interesting but it's not what's done right now in yacpdb. It's clearly better than the current mess, which comes over as an insult to anyone who makes a version or correction. Some details of problemXML would need work before implementation:

(1) There is no inheritance of data between one release and its base. So we have the odd situation, shown in the Maeder example, where the original author must be shown as the first of the correctors, even if they had no role in the correction (e.g. deceased 100 years before). This is ambiguous.

(2) There is no way to show "afteree", which can also use the composer master data for quality and search. I guess this would be a separate field again.

Thanks for all your work!

All the best, Andrew