search

dturing / node-gstreamer-superficial

Superficial gstreamer binding
MIT License
127 stars 45 forks source link

Write message to bus #15

Closed macdudeuk closed 7 years ago

macdudeuk commented 7 years ago

Hi guys. If anyone feels like tackling it, it would be great to have a way to send a message to the GStreamer bus. In particular sending EOS before tearing down a pipeline.In fact a way to cleanly close a pipeline in general. If you are recording anything to a file this is pretty much mandatory and would make this module useful in more situations. Sadly such an enhancement is past my capabilities...

PS Love it so far.

macdudeuk commented 7 years ago

Actually I have amazed myself and have made and tested the changes to add pipeline.sendEOS(). Turned out to be trivial. I have done it outside of GIT (which I have no idea how to use) so have attached the two changed files. Sorry for being so lame!

Pipeline.cpp.txt Pipeline.h.txt

macdudeuk commented 7 years ago

I worked out how to make a pull request. Yay!

dturing commented 7 years ago

Continued in #16 ; thanks.