search

dturing / node-gstreamer-superficial

Superficial gstreamer binding
MIT License
127 stars 45 forks source link

Add <pipeline>.sendEOS() #16

Closed macdudeuk closed 7 years ago

macdudeuk commented 7 years ago

See issue raised.

This is a simple change to add the ability to send an EOS message to the pipeline. This is important as it allows the pipeline to sort itself out (such as flush buffers and close files) before a pipeline.stop(),

A more generic messaging capability would be better, but this is simple and meets the basic requirement.

dturing commented 7 years ago

Hey, sorry for not responding any earlier.

Thanks for .sendEOS()! "simple and meets the basic requirement" exactly fits node-gstreamer-superficial's development philosophy ;)

Can you please add yourself to package.json/contributors? Then i'll gladly accept this PR.