search

dturing / node-gstreamer-superficial

Superficial gstreamer binding
MIT License
130 stars 45 forks source link

Precomplier flags for gstreamer versions that don't have gst_pipeline… #8

Closed gregfutia closed 7 years ago

gregfutia commented 7 years ago

…_set_latency and gst_pipeline_get_latency added in gstreamer v.1.11.

Link to gstreamer source the gstreamer V. 1.11 number came from

This the precompiler flags as a separate pull request. If it's 1.6 instead I don't think I'd pull this into master.

dturing commented 7 years ago

That commit is from 11 Jun 2015, and tagged not only 1.11.1 (the latest current release in gstreamer's "unstable" series), but also 1.5.2 (probably the next release in gst-unstable when the patch was commited) and anything in between, incl. 1.6.0. So i'm pretty sure gstreamer documentation is correct where it says "Since: 1.6" :)

Like you, I see no need to add precompiler checks for a stable version that old... i guess you're hit by debian's slow pace again (as with your old node version earlier :).

If you find a good way to require gst > 1.6 though, maybe by a flag to the pkg-config calls in package.json, that would be a nice addition that could help someone trying to install gstreamer-superficial on debian...

gregfutia commented 7 years ago

The docs say 1.6. My code should be at least changed to 1.6 then. The master shouldn't be cluttered with this. -> closed

How to support older gstreamer/node versions is another issue. Like you point to, at least telling the user is a good start. Fixing the problem would mean the installer puts patches like mine in for installs on older systems. I have no idea if that's supported in npm. I guess npm would have to install from different branches depending on system information.

Getting the install requirements better enforced would help in informing the user. Previously, it didn't complain about my 0.12 node version in spite of the

"engines": { "node": ">= 5.9.1" }, in the package.json.