dtvala2930
commented
3 months ago I appreciate your feedback. I took it as a lesson for myself. I'll investigate the problem and follow the interview process. Best wishes and have a nice day.
Vào Th 6, 19 thg 7, 2024 vào lúc 16:53 Xavier MALPARTY < @.***> đã viết:
Hello Tan, 👋
Thank you for your effort in submitting the code. I am Xavier, Team Lead at Nimble, and I am happy to be the reviewer for our code review session.
During the review process, I would like to know more about your decisions, so I will create issues in some areas where your submission could be improved. Since solving every possible problem would take too long, I will prioritize the most important ones.
At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to ask questions or share your opinions about the implementation (if any) during the process.
We expect the code review process to be completed within 2-3 days. As a result, please make sure you are responsive during this process. If you need more time, please let us know as soon as possible so we can plan accordingly.
If we are aligned on any issue, and you would like to correct them, please address the issue using a proper git flow (creating a new branch, opening a Pull Request (PR) per issue, and merging the code when you are ready), and I will follow up on those fixes. So that you know, you don't have to close any of my created issues after merging your PRs; I will help verify and close them for you once they pass. 😇
In the end, I do hope that you find the process enjoyable. Good luck and happy coding. 🤘
— Reply to this email directly, view it on GitHub https://github.com/dtvala2930/BE/issues/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIQ6PLNQGBR6MCSPUQQRWZ3ZNDOYJAVCNFSM6AAAAABLEIS662VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYTQNJRGU3TCOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
malparty
Hello Tan, 👋
Thank you for your effort in submitting the code. I am Xavier, Team Lead at Nimble, and I am happy to be the reviewer for our code review session.
During the review process, I would like to know more about your decisions, so I will create issues in some areas where your submission could be improved. Since solving every possible problem would take too long, I will prioritize the most important ones.
At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to ask questions or share your opinions about the implementation (if any) during the process.
We expect the code review process to be completed within 2-3 days. As a result, please make sure you are responsive during this process. If you need more time, please let us know as soon as possible so we can plan accordingly.
If we are aligned on any issue, and you would like to correct them, please address the issue using a proper git flow (creating a new branch, opening a Pull Request (PR) per issue, and merging the code when you are ready), and I will follow up on those fixes. So that you know, you don't have to close any of my created issues after merging your PRs; I will help verify and close them for you once they pass. 😇
In the end, I do hope that you find the process enjoyable. Good luck and happy coding. 🤘