[Bug] User cannot register

[malparty]

Issue

When the user fills in the registration form and submits it:

• On the deployed app, the loading spinner spins forever
• On the local app: nothing happens

In both cases, there is no visible log (browser and server logs).

Expected

When a user submits a form, any error should be logged on the server side at least. At best, an alert gracefully handles the error and recommends what the user should try next (retry, contact admin, etc.).

[!NOTE] I'll pause the code review until this can be fixed, as it is a bit time-consuming to review the entire project without running it.

[dtvala2930]

I understood the problem. Because I am using the free tier of hosting BE, it would take a long time to run and handle requests. I may try a new method and deploy BE on another platform.

Vào Th 6, 19 thg 7, 2024 vào lúc 16:56 Xavier MALPARTY < @.***> đã viết:

Issue

When the user fills in the registration form and submits it:

• On the deployed app, the loading spinner spins forever
• On the local app: nothing happens

In both cases, there is no visible log (browser and server logs). Expected

When a user submits a form, any error should be logged on the server side at least. At best, an alert gracefully handles the error and recommends what the user should try next (retry, contact admin, etc.).

Note

I'll pause the code review until this can be fixed, as it is a bit time-consuming to review the entire project without running it.

— Reply to this email directly, view it on GitHub https://github.com/dtvala2930/BE/issues/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIQ6PLNV2MYPQ7XOP5KOBWDZNDPGJAVCNFSM6AAAAABLEIYNASVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYTQNJSGIZTQMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[dtvala2930]

[image: Screenshot 2024-07-19 at 18.29.47.png] I will try another method. Sorry for the inconvenience.

Vào Th 6, 19 thg 7, 2024 vào lúc 18:24 Tân Nguyễn @.***> đã viết:

I understood the problem. Because I am using the free tier of hosting BE, it would take a long time to run and handle requests. I may try a new method and deploy BE on another platform.

Vào Th 6, 19 thg 7, 2024 vào lúc 16:56 Xavier MALPARTY < @.***> đã viết:

Issue

When the user fills in the registration form and submits it:

• On the deployed app, the loading spinner spins forever
• On the local app: nothing happens

In both cases, there is no visible log (browser and server logs). Expected

When a user submits a form, any error should be logged on the server side at least. At best, an alert gracefully handles the error and recommends what the user should try next (retry, contact admin, etc.).

Note

I'll pause the code review until this can be fixed, as it is a bit time-consuming to review the entire project without running it.

— Reply to this email directly, view it on GitHub https://github.com/dtvala2930/BE/issues/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIQ6PLNV2MYPQ7XOP5KOBWDZNDPGJAVCNFSM6AAAAABLEIYNASVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYTQNJSGIZTQMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[dtvala2930]

I have updated the BE host tier. Please check and let me know if any problems occur. Best wishes, and have a nice weekend.

Vào Th 6, 19 thg 7, 2024 vào lúc 18:31 Tân Nguyễn @.***> đã viết:

[image: Screenshot 2024-07-19 at 18.29.47.png] I will try another method. Sorry for the inconvenience.

Vào Th 6, 19 thg 7, 2024 vào lúc 18:24 Tân Nguyễn < @.***> đã viết:

I understood the problem. Because I am using the free tier of hosting BE, it would take a long time to run and handle requests. I may try a new method and deploy BE on another platform.

Vào Th 6, 19 thg 7, 2024 vào lúc 16:56 Xavier MALPARTY < @.***> đã viết:

Issue

When the user fills in the registration form and submits it:

• On the deployed app, the loading spinner spins forever
• On the local app: nothing happens

In both cases, there is no visible log (browser and server logs). Expected

When a user submits a form, any error should be logged on the server side at least. At best, an alert gracefully handles the error and recommends what the user should try next (retry, contact admin, etc.).

Note

I'll pause the code review until this can be fixed, as it is a bit time-consuming to review the entire project without running it.

— Reply to this email directly, view it on GitHub https://github.com/dtvala2930/BE/issues/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIQ6PLNV2MYPQ7XOP5KOBWDZNDPGJAVCNFSM6AAAAABLEIYNASVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYTQNJSGIZTQMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[malparty]

I've tried to register from https://interview-3d75e.web.app/register and it was still not working. This time I have a 400 Bad Request error:

{"statusCode":400,"message":"Bad Request Exception"}

After more investigation, I found out that the server requires both lowercase and uppercase letters.

[!NOTE] A good practice to handle errors is to have the server return an error message and to display this message to the user.

I will continue the assessment now.

[dtvala2930]

Thanks for the feedback. I notice and wait for your further review messages.

Vào Th 2, 22 thg 7, 2024 vào lúc 10:22 Xavier MALPARTY < @.***> đã viết:

I've tried to registered from https://interview-3d75e.web.app/register but it is still not working. This time I have a 400 Bad Request error:

{"statusCode":400,"message":"Bad Request Exception"}

After more investigation, I found out that the server requires both lowercase and uppercase letters.

Note

A good practice to handle errors is to have the server return an error message and to display this message to the user.

I will continue the assessment now.

— Reply to this email directly, view it on GitHub https://github.com/dtvala2930/BE/issues/4#issuecomment-2241967929, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIQ6PLIG6HJK7DMO5EG67YDZNR3ILAVCNFSM6AAAAABLEIYNASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBRHE3DOOJSHE . You are receiving this because you commented.Message ID: @.***>