search

dtwrks / elm-book

Rich documentation builder for Elm applications and packages. Inspired by Storybook and HexDocs.
http://elm-book-in-elm-book.netlify.app
Mozilla Public License 2.0
96 stars 8 forks source link

bug: when hashBasedNavigation is true and url route can't be found, apps become unresponsive #48

Open giacomocerquone opened 2 months ago

giacomocerquone commented 2 months ago

When hashBasedNavigation is true and a 404 link is pressed, there is an infinite update loop that makes the app go totally unresponsive. To reproduce this just convert the UI folder of this repo to use the hashBasedNavigation and insert an inexistent link wherever you want and notice the behavior.

FYI: Right now links in markdown when hashBasedNavigation is true should start with an hashtag (#/guides/whatever), but the bug can be reproduced either way of course.

Check the screencast:

https://github.com/user-attachments/assets/b4bcf1fe-4beb-4503-a6d5-8829ff16d9fe

Please notice the url which demonstrate I'm hitting an inexistent link.

Screenshot 2024-08-22 at 00 26 45

giacomocerquone commented 2 months ago

Btw you @georgesboris probably noticed already this issue here in #7