search

dtzar / helm-kubectl

Docker Hub image with helm and kubectl on top of alpine linux with bash
https://hub.docker.com/r/dtzar/helm-kubectl/
MIT License
365 stars 133 forks source link

add jq #33

Closed smatyas closed 4 years ago

smatyas commented 5 years ago

Hi, would you consider adding jq to the image?

I understand if you don't want to bloat the image, but I found jq pretty useful when working with helm outputs.

My specific use case is: get the current deployed setting of a value conditionally

Using jq inside the build script, I can decide on which version to deploy:

if [ ${params.buildVarnish} = true ]; then
  HELM_TAG_VARNISH="${params.dockerImageTag}"
else
  HELM_TAG_VARNISH=`helm get values my-release --output json | jq -r '.varnish.tag'`
fi

helm upgrade my-release my-chart \
  --set-string nginx.tag=${HELM_TAG_NGINX},varnish.tag=${HELM_TAG_VARNISH}
dtzar commented 5 years ago

Since this adds ~4 MB and we now have a bunch of people depending on / using this container (over 1 Million downloads) - I'd like to know there are others who really want (or not) this before adding it. How about I keep this PR open and you file an issue here and see what the community voice might be?

smatyas commented 4 years ago

After 5 months, there seem to be very few support/interest about this issue. (Or three times more approval then opposition from another point of view :))

Anyway, I'm closing this PR in favor of my dependant image that does include jq and yq as well: https://hub.docker.com/r/smatyas/helm-kubectl-plus

It will follow the releases of this repository.

Cheers!