search

dtzar / helm-kubectl

Docker Hub image with helm and kubectl on top of alpine linux with bash
https://hub.docker.com/r/dtzar/helm-kubectl/
MIT License
365 stars 133 forks source link

chore(library): add gettext #82

Closed BlackHole1 closed 3 years ago

BlackHole1 commented 3 years ago

because envsubst is very useful in certain scenarios.

e.g:

# helm/values.yaml file
configmap:
    MYSQL_USERNAME: ${MYSQL_USERNAME}
export MYSQL_USERNAME=root

export VALUES=`envsubst < helm/values.yaml`
echo $VALUES > helm/values.yaml

cat helm/values.yaml
# => configmap:
# =>     MYSQL_USERNAME: root
gaby commented 3 years ago

Looks good to me, I didn't even know gettext was a thing, this would be useful for CI/CD stages.

I can merge it once the new Helm release comes out this week.

BlackHole1 commented 3 years ago

@gaby can you release a latest first?

because I need to use it now, otherwise, I need to fork this project and republish a new docker image

gaby commented 3 years ago

@BlackHole1 Helm 3.5.4 is schedule to be released tomorrow, that will also update the latest, 3, and 3.5.4 tags.

BlackHole1 commented 3 years ago

Okay, then I will release a temporary docker image first, and then I will replace it after the PR is merged