feat: improve Orderbook UI and buy/sell orders - Githubissues

duality-labs / duality-web-app

2 stars 2 forks source link

feat: improve Orderbook UI and buy/sell orders #539

Closed dib542 closed 6 months ago

dib542 commented 7 months ago

This PR cleans up parts of the Buy/Sell card of the Orderbook UI

adds Order Type help: link to docs
changes the layout of token pair prices to read eg: price 10 of pair ATOM/USDC can be read as 10USDC per ATOM
- this shifts the order of many token pairs
fix loading states and warning/error display
- reverts some of the workarounds of using Immediate or Cancel simulations to avoid the Swap amount too small errors. Now it should display these errors
fix SelectInput closing behavior

And is based on the previous work in the PRs

537
541
- with updates to add support for all order types that are currently available

Preview: localhost_5173_orderbook_USDC_NTRN(FullHD) (4)

github-actions[bot] commented 7 months ago

Deploy Previews

Testnet

Preview URL: https://e0c22e90-d7087c85--duality-xyz-testnet.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/65f3150375b329ed23b180f5

Beta

Preview URL: https://e0c22e90-d7087c85--duality-xyz-beta.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/65f31550a7ffb3eccfc2f61f

github-actions[bot] commented 6 months ago

Deploy Previews

Testnet

Preview URL: https://4872f871-ae7ed2c8--duality-xyz-testnet.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/6612fea9825107fc7302e6b4

Beta

Preview URL: https://4872f871-ae7ed2c8--duality-xyz-beta.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/6612fef3dfac42fe43cf4fc6

github-actions[bot] commented 6 months ago

Deploy Previews

Testnet

Preview URL: https://bd6f5eed-d1442067--duality-xyz-testnet.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/6613c9fdbdfc6f89beba0258

Beta

Preview URL: https://bd6f5eed-d1442067--duality-xyz-beta.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/6613ca48daf78d8920a23f76

github-actions[bot] commented 6 months ago

Deploy Previews

Testnet

Preview URL: https://5e0ff50f-d139c3e4--duality-xyz-testnet.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/6614b00cde6f265028be1849

Beta

Preview URL: https://5e0ff50f-d139c3e4--duality-xyz-beta.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/6614b056cc32ff4b02e20912

github-actions[bot] commented 6 months ago

Deploy Previews

Testnet

Preview URL: https://da793c38-a325755d--duality-xyz-testnet.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/66151f90a08b30a9dbe44670

Beta

Preview URL: https://da793c38-a325755d--duality-xyz-beta.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/66151fd9a9711ca7e5b8d3f6

github-actions[bot] commented 6 months ago

Deploy Previews

Testnet

Preview URL: https://efa628f2-22f42a9f--duality-xyz-testnet.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/6615237b5c0801ab7ec4126c

Beta

Preview URL: https://efa628f2-22f42a9f--duality-xyz-beta.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/661523c83fbea7a7260bddeb

github-actions[bot] commented 6 months ago

Deploy Previews

Testnet

Preview URL: https://161502fe-ff9c4413--duality-xyz-testnet.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/661524d400f6fa6c238842cf

Beta

Preview URL: https://161502fe-ff9c4413--duality-xyz-beta.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/6615251fbb523caca1b806b1

github-actions[bot] commented 6 months ago

Deploy Previews

Testnet

Preview URL: https://6bafd3a0-c2fb53d2--duality-xyz-testnet.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/66152bef3fda61b480e53525

Beta

Preview URL: https://6bafd3a0-c2fb53d2--duality-xyz-beta.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/66152c3afb4241060a3004fc

github-actions[bot] commented 6 months ago

Deploy Previews

Testnet

Preview URL: https://eeca9d7c-96a07a9b--duality-xyz-testnet.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/66155da53b85620c3bdfd4ef

Beta

Preview URL: https://eeca9d7c-96a07a9b--duality-xyz-beta.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/66155deee42d7209d0d86cc6

dib542 commented 6 months ago

The UI tests are currently failing because the Swap page is hitting a Swap amount too small error and it cannot click the "Swap" button:

localhost_5173_swap_OSMO_NTRN(4_3)

github-actions[bot] commented 6 months ago

Deploy Previews

Testnet

Preview URL: https://67776af6-6423a894--duality-xyz-testnet.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/661568703d949913da9b9349

Beta

Preview URL: https://67776af6-6423a894--duality-xyz-beta.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/661568bc57e508148a2e3ab9

MrTalecky commented 6 months ago

The falling UI test needs improvement, I'll fix that later.

github-actions[bot] commented 6 months ago

Deploy Previews

Testnet

Preview URL: https://283a0c40-b7ba4f89--duality-xyz-testnet.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/661584490741ab155bd8aec4

Beta

Preview URL: https://283a0c40-b7ba4f89--duality-xyz-beta.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/661584970a2e5915cc6c6089

dib542 commented 6 months ago

:tada: This PR is included in version 2.6.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: