search

duality-labs / duality-web-app

2 stars 2 forks source link

fix: Select Input UI should not close before selecting input #550

Closed dib542 closed 4 months ago

dib542 commented 4 months ago

This PR attempts to improve the selection behavior of the SelectInput component.

Previously the SelectInput component could sometimes close before confirming the selection of a new option. This is very frustrating because when it happens it makes the SelectInput component unusable and the value in the form cannot be changed from the default selection.

Now the component no longer relies on a setTimeout to close the selection options and instead relies on the completion of specific actions which should always occur after a new option is selected.

github-actions[bot] commented 4 months ago

Deploy Previews

Testnet

Preview URL: https://256ee9d1-9e898666--duality-xyz-testnet.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/662a5715529235c98ea4ade3

Beta

Preview URL: https://256ee9d1-9e898666--duality-xyz-beta.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/662a57611c8abd1a224a1f8a

dib542 commented 4 months ago

Using the Tab key to move through select options does not work on Safari (pressing Tab key closes the select option pane)

github-actions[bot] commented 4 months ago

Deploy Previews

Testnet

Preview URL: https://1bf75b10-c84759ed--duality-xyz-testnet.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/6632d689e2732a3aed94de98

Beta

Preview URL: https://1bf75b10-c84759ed--duality-xyz-beta.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/6632d6d68469fc37be5eea35

dib542 commented 4 months ago

:tada: This PR is included in version 2.8.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: