search

duality-labs / duality-web-app

2 stars 2 forks source link

fix: limit market order should set limit to current market price #561

Closed dib542 closed 3 months ago

dib542 commented 3 months ago

This PR fixes a small issue in the Orderbook where selecting a "Limit order" using the market price would result in a trade of a price of 1 exactly, because the logic to use "current market price" for this was missed.

It also adds some logging ability into the app, to allow more visibility to created Tx payloads by default (at log level REACT_APP__LOG_LEVEL=Info)

github-actions[bot] commented 3 months ago

Deploy Previews

Testnet

Preview URL: https://a6ba7117-87650b40--duality-xyz-testnet.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/665fe0a559ade49e136ac062

Beta

Preview URL: https://a6ba7117-87650b40--duality-xyz-beta.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/665fe0f1f1ccec98d06722be

github-actions[bot] commented 3 months ago

Deploy Previews

Testnet

Preview URL: https://12284ce7-42a73cb7--duality-xyz-testnet.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/66602d69b58c8fe23abc8e06

Beta

Preview URL: https://12284ce7-42a73cb7--duality-xyz-beta.netlify.app Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/66602db886974fe0d38297f9

dib542 commented 3 months ago

:tada: This PR is included in version 2.11.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: