duality-labs / duality

Apache License 2.0
10 stars 5 forks source link

Calculated outShares = 0 impact #321

Closed jcompagni10 closed 1 year ago

jcompagni10 commented 1 year ago

DepositCore() During calculations of outShares in code - it could be interesting if inAmounts are not = 0. We tried to catch this case with an integration test, but without any success of hitting the exact case. However, it should be considered whether it is possible to calculate outShares to 0 and inAmounts != 0, and what the possible consequences are.