search

duality-solutions / Sequence

Sequence(SEQ)
https://duality.solutions
MIT License
17 stars 8 forks source link

Stake received 1.999 instead of 2.000 #106

Closed AmirAbrams closed 6 years ago

AmirAbrams commented 7 years ago

Describe the issue

The stake reward is sometimes 1.999 instead of 2.000.

Steps to reproduce

Unable to reproduce the issue but if you receive enough stake rewards, you will see it happen. See tx: 3e6e9d58b662bbf1900b935428f75cbdb9c9fc85b011becd17e38593be9f4da2

Expected behavior

The stake reward should always be 2.000.

Duality-CDOO commented 6 years ago

Fee indiscrepency in the codebase.

Duality-CDOO commented 6 years ago

https://github.com/duality-solutions/Sequence/blob/v1.2-WIP/src/wallet/wallet.cpp#L2674 should not have "- nMinFee".

Nor should line 2671.

This will need to be a fork.

Duality-CDOO commented 6 years ago

https://github.com/duality-solutions/Sequence/commit/b833e6f937c2d7f77a63ea7925b4f4d9bbfe7aaf

Duality-CDOO commented 6 years ago

Will change the check to be for block.nversion instead and up the version to 3

Duality-CDOO commented 6 years ago

Fixed in 1.3