TODO

[duaraghav8]

• [ ] Improve no-assign-params message to point out the exact param that's being modified instead of just mentioning function name
• [ ] Refine no-explicit-visibility rule.
• [ ] Coverage
• [ ] Tests for remaining rules (that are in prod in v0.2.0) + package.json tests (just like in Solium)
• [ ] README: add augur bounty in description "these rules have been taken from..."
• [x] Fully document how #25 has been resolved
• [x] Travis ensure success
• [x] Add Augur & all bounty participants' name in docs (under community section)
• [x] remove list-of-rules.tgn
• [x] run eslint - standardize indentation, quotes, bracketing, etc.
• [x] Arrange rules alphabetically in readme, index.js etc (if necessary)

Types of refinement to be done

• [x] Renaming
• [x] refactoring of rule implementations
• [x] recommended = true/false
• [x] type (default severity or switched off) (https://github.com/duaraghav8/Solium/issues/142)
• [x] more automated tests

[vibern0]

I've found that there's actually some tests failing. Is it tests error or the linter?

[duaraghav8]

Tests could fail due to various reasons, the primary one being if you're running solium on windows. Could you paste the output of test failures

[vibern0]

I'm running on linux mint, please.

The errors are actually tests that fail.

1) [RULE] no-abstract-func: Rejections
       should reject contracts that use abstract functions:

      AssertionError: expected 0 to be 1
      + expected - actual

      -0
      +1

      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/no-abstract-func.js:57:34)

  2) [RULE] no-void-returns: Rejections
       should reject functions that have a void return:

      AssertionError: expected 0 to be 1
      + expected - actual

      -0
      +1

      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/no-void-returns.js:48:34)

  3) Checking package.json
       should enforce fixed versions on certain dependencies:
     AssertionError: expected false to be true
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.value (node_modules/should/cjs/should.js:356:19)
      at fixedDevDeps.forEach.fdd (test/packagejson.js:24:59)
      at Array.forEach (<anonymous>)
      at Context.done (test/packagejson.js:23:22)