Added no-assign-parameter rule

duaraghav8 / solium-plugin-security

The Official Security Plugin for Ethlint (formerly Solium)

http://npmjs.com/package/solium-plugin-security

MIT License

44 stars 12 forks source link

Added no-assign-parameter rule #18

Closed Cisplatin closed 7 years ago

Cisplatin commented 7 years ago

As requested in https://augur.net/bounties/: an implementation of the rule 'Do not assign to parameters'.

Please let me know if there's anything I can change!

Cisplatin commented 7 years ago

@duaraghav8 Fixed the cases that you were talking about - great catches, missed those. Everything should be working properly now.

Cisplatin commented 7 years ago

@duaraghav8 Good catch (again) with the false negatives - I've fixed the recursive solution so that it properly traverses the code. I also added the tests you mentioned to make sure that it works.

Cisplatin commented 7 years ago

@duaraghav8 Fixed up the error message!