duaraghav8 / solium-plugin-security

The Official Security Plugin for Ethlint (formerly Solium)
http://npmjs.com/package/solium-plugin-security
MIT License
44 stars 12 forks source link

Add a no-interface option to no-inheritance and no-multiple-inheritance #20

Closed nfeignon closed 7 years ago

nfeignon commented 7 years ago

In response to Augur bounties: "Prohibit use of multiple inheritance but allow interfaces" and "Prohibit use of inheritance but allow interfaces".

Let me know if there's anything to fix.

duaraghav8 commented 7 years ago

@nfeignon I had a discussion about these 2 rules with tinybike. They need to be merged with no-inheritance & no-multiple-inheritance respectively. How this works is:

Can you please augment the changes into the existing rules? Sorry to cause you the trouble, but this approach is much more elegant. NOTE: modifying the existing rules is treated as 2 new rules submitted and bounty awarded accordingly

nfeignon commented 7 years ago

Updated my PR. Let me know if there's anything to fix!

duaraghav8 commented 7 years ago

@nfeignon I've requested 2 changes in no-inheritance. They also apply to no-multiple-inheritance. Everything else is good.

nfeignon commented 7 years ago

Updated the PR and rebased :)