duartegroup / autodE

automated reaction profile generation
https://duartegroup.github.io/autodE/
MIT License
165 stars 51 forks source link

Fix xtb opt with cartesian coordinates #247

Closed t-young31 closed 1 year ago

t-young31 commented 1 year ago

Resolves #245

Fixes cartesian coordinate constraints in XTB optimisations. I'm not convinced this ever worked correctly!


Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #247 (5f3151a) into v1.3.5 (0d03666) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head 5f3151a differs from pull request most recent head 53ee7b6. Consider uploading reports for the commit 53ee7b6 to get more accurate results

@@           Coverage Diff           @@
##           v1.3.5     #247   +/-   ##
=======================================
  Coverage   97.14%   97.15%           
=======================================
  Files         196      196           
  Lines       20172    20183   +11     
=======================================
+ Hits        19597    19608   +11     
  Misses        575      575           
Flag Coverage Δ
unittests 97.15% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
autode/wrappers/XTB.py 98.53% <100.00%> (-0.03%) :arrow_down:
tests/test_wrappers/test_xtb.py 99.47% <100.00%> (+0.04%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.