Open aleksy-k opened 1 year ago
Thanks for raising this – certainly a bug. rdkit_conf_gen_is_fine
is public so autodE conformer generation can be used when RDKit also works (docs) and there's no test that it works the other way round.
Would be a nice feature to be able to override the rather opinionated choices. I'd vote having Config.molecule_conformer_method
as an enum of {Default, RDKit, autodE}
– what do you think?
Describe the bug
For some molecules with explict hydrogens in their SMILES (e.g. O=C1C2=C(OC)C=C(OC)C=C2CC3(SCCCS3)/C=C/C=C[C@]4([H])C@(O4)CC@@HO1 ) there is a mismatch in atom ordering if you try to force RDKit conformer generation.
Raises: ValueError( "Cannot alter the atomic symbols of a " "conformer. Parent molecule was different: " f"{atom.label} != {parent_atom.label}"
Would be good if there is an argument for the user to override RDKit vs autodE automatic conformer generation method choice. Additionally not sure why rdkit_conf_gen_is_fine is not private.
To Reproduce
Expected behavior
Environment