duartegroup / autodE

automated reaction profile generation
https://duartegroup.github.io/autodE/
MIT License
168 stars 51 forks source link

ImportError: cannot import name 'cached_property' from 'functools' #290

Closed j3mdamas closed 1 year ago

j3mdamas commented 1 year ago

Describe the bug As per title. Snipped version of output:

File "/tmp/autodE/autode/hessians.py", line 8, in <module>
    from functools import cached_property
ImportError: cannot import name 'cached_property' from 'functools'

To Reproduce Install with Python 3.7, and try the example code on https://duartegroup.github.io/autodE/install.html#installation-check

Expected behavior No import error

Environment

Basically, the code has an import of cached_property that was only introducted in Python 3.8 (https://docs.python.org/3/library/functools.html#functools.cached_property), but the README and setup.py says the minimum Python version is 3.7, and the documentation says 3.6

t-young31 commented 1 year ago

Hi @j3mdamas – the readme and setup.py say ">3.7" i.e. not inclusive of, sorry! Documentation elsewhere may very well be wrong. The minimum Python version is definitely 3.8

j3mdamas commented 1 year ago

Apologies, I guess I'm more used to see inclusive requirements. Closing.