duarteguilherme / congressbr

An R package that returns tidy data from the APIs of the Brazilian Federal Senate and Chamber of Deputies.
https://robertmyles.github.io/congressbr/
Other
43 stars 6 forks source link

standardize names #12

Closed RobertMyles closed 7 years ago

RobertMyles commented 7 years ago

Just check to standardize the variable names in the data frames returned. If one df has party_id, for example, the same info should be party_id in all data frames, unless it's very specific to something else.

RobertMyles commented 7 years ago

For example, there are variables in the Senate part that are bill_number, whereas in the Chamber they are number_bill. Let's standardize them? (I'm going to suggest the Senate way :-D )

danilofreire commented 7 years ago

Other things should probably be standardised too:

@RobertMyles and @duarteguilherme, any ideas?

duarteguilherme commented 7 years ago

I'll standardize bill_number later.

duarteguilherme commented 7 years ago

What do you think about "cham" instead of "cam"? I think it's a better option

danilofreire commented 7 years ago

Yes, I wrote that on Facebook a few minutes ago. It could either be cha_ or cham_, although the last sounds better to me. It's easier to pronounce in English.

RobertMyles commented 7 years ago

cham_ looks good to me.

danilofreire commented 7 years ago

Great, so let's rename the functions. I can do it if you guys want me to, then update the vignettes. Is that okay?

duarteguilherme commented 7 years ago

Just have to update the vignettes

danilofreire commented 7 years ago

Closed with commit #1f9fcd1. I checked every function and updated the vignettes. The package compiles without errors on my machine.