Closed RobertMyles closed 7 years ago
For example, there are variables in the Senate part that are bill_number
, whereas in the Chamber they are number_bill
. Let's standardize them? (I'm going to suggest the Senate way :-D )
Other things should probably be standardised too:
sen_
for the senate, wouldn't it be better to use cha_
for the chamber of deputies? cam_bill_info_tny.R
to cam_bill_info.R
would be more intuitivecam_bill_info_tny.R
into the new function, with bill id as an argument@RobertMyles and @duarteguilherme, any ideas?
I'll standardize bill_number later.
What do you think about "cham" instead of "cam"? I think it's a better option
Yes, I wrote that on Facebook a few minutes ago. It could either be cha_
or cham_
, although the last sounds better to me. It's easier to pronounce in English.
cham_
looks good to me.
Great, so let's rename the functions. I can do it if you guys want me to, then update the vignettes. Is that okay?
Just have to update the vignettes
Closed with commit #1f9fcd1. I checked every function and updated the vignettes. The package compiles without errors on my machine.
Just check to standardize the variable names in the data frames returned. If one df has
party_id
, for example, the same info should beparty_id
in all data frames, unless it's very specific to something else.