search

dubhater / vapoursynth-mvtools

Motion compensation and stuff
184 stars 28 forks source link

MFlowInter crashes with certain combination of hpad/vpad, pel, blksize, search, overlapv and divide #36

Closed zorrozork closed 5 years ago

zorrozork commented 5 years ago

I found another crash, it happens with these parameters to MAnalyze and MFlowFPS: hpad/vpad = 0 pel = 4 blksize = 64 search != 6 overlapv = 8 divide = 0

I'm not sure which of the issues I have filed to Avisynth MVTools is closest to this one, but it's possible some of them are related.

mvtools4_error.zip

Attached is a script which triggers the error on frame 7 of my test video which had frame size 720x680. If you have problems reproducing the error I can provide the source video as well. There are more detailed test results in the script comments.

My system is Windows 10, VapourSynth R45 64-bit (I'm using the portable FATPACK) and latest MVTools version (not released yet but provided by you in the previous issue).

dubhater commented 5 years ago

Please try this MVTools DLL.

zorrozork commented 5 years ago

Thanks! Unfortunately there's still a crash. Here's a short video to reproduce it, it crashes on frame 7. video.zip

dubhater commented 5 years ago

Hmm, I think I see the problem, but the Avisynth version should still have it too.

zorrozork commented 5 years ago

You're right, the same bug exists in Avisynth version. I'll make a bug report there too. I probably didn't notice this before because I didn't run tests with hpad / vpad and the default value for those is 8.

dubhater commented 5 years ago

Same name, but the bug should be fixed now: mvtools-v20+issue36-win64.zip

zorrozork commented 5 years ago

Thanks, works on my end too. Pinterf fixed his version also so all is good. :)

theChaosCoder commented 5 years ago

Will you make a new release with this fix?

dubhater commented 5 years ago

Oh, yeah. I was waiting to see if another bug appeared, and then I forgot.