search

dubhater / vapoursynth-mvtools

Motion compensation and stuff
181 stars 27 forks source link

Fixes for ARM #55

Closed Stefan-Olt closed 1 month ago

Stefan-Olt commented 2 years ago

This fixes the build issues on ARM, is it possible to merge and create a new release? This would make it possible for the brew package manager to update it's package of mvtools without much hassle so it's working on Apple Silicon.

Stefan-Olt commented 2 months ago

Any chance of merging this pull request and making mvtools usable on Apple Silicon? I would rebase the the pull request to the latest git for that

dubhater commented 2 months ago

It looks nice.

Stefan-Olt commented 2 months ago

Great, thanks! I'll rebase it in the next days, test it and commit it, is that okay?

Since the last release some features have been added, is there anything specific left to do for a new release?

dubhater commented 2 months ago

I don't know, I haven't looked at this repository in years.

adworacz commented 2 months ago

Looks like there’s no corresponding updates to the Meson build files, which we’ll likely want to add.

@dubhater im thinking about removing the old configure scripts so we can just have a single build system (Meson) instead of managing two. Any qualms with just supporting Meson going forwards?

dubhater commented 2 months ago

You should ask the new maintainer. :)

Stefan-Olt commented 2 months ago

I'm not sure if/how I got the job, but I don't see any specific reason why two build systems are necessary unless there is a specific need (for example the build systems cover different platforms). If meson can do everything autotools can do, just better, I'm fine with removing autotools build system. I found these three repos that build the plugin:

So with the next release we need to update the homebrew formula to use meson (I can do that). I hope the Debian maintainer will notice the change.

It would be great if you could update the meson build files to support arm64/aarch64

adworacz commented 2 months ago

Yeah, Meson is simpler to work with than autotools, and tries hard to do the right thing by default.

Updating the Meson build files to support arm64/aarch64 should be simple. It likely has most of the work done already, but with this PR, maybe we'll just need to get it updated to define the proper args.