search

dubhater / vapoursynth-mvtools

Motion compensation and stuff
181 stars 27 forks source link

api4 support? #68

Closed Selur closed 1 month ago

Selur commented 1 year ago

When using mvtools with Vapoursynth R63 I get: Explicitly instantiated a Cache. This is no longer possible and the original clip has been passed through instead. Would be nice if mvtools could be updated. see: https://forum.doom9.org/showthread.php?p=1988871#post1988871

dubhater commented 1 year ago

You can do it!

Selur commented 1 year ago

I have 0-knowledge about mvtool and its inner workings, just wanted to point out there is an issue.

adworacz commented 2 months ago

I might look into this. I’m not sure what all work is required, but I’d expect the changes shouldn’t be too challenging.

I also have some small bug fixes I need to get a PR together for.

I’ll start looking into this in the next week or two.

Stefan-Olt commented 2 months ago

Great, do you know if some of your work is interfering with my ARM patches? I hope I can finish updating them this week

adworacz commented 2 months ago

I took a quick look at your changes, and there didn’t seem to be any conflict with the upcoming API changes.

The only thing might be related to the build system, so we’ll see what dubhater says.

adworacz commented 1 month ago

Note that I have a branch where I've started porting to API v4: https://github.com/adworacz/vapoursynth-mvtools/tree/apiv4

I've got Super, Analyse, and Degrain ported so far. So far, the changes are minimal and seem to work just fine, but I'd appreciate some help in testing to make sure I haven't bungled anything once we merge the changes.

Stefan-Olt commented 1 month ago

I'll do some testing next week

adworacz commented 1 month ago

Yeah no rush yet, I’d like to get a few more filters ported to make it worth your while.