dubiety / terraform-aws-elasticsearch-cloudwatch-sns-alarms

terraform module that configures important alarms for AWS elasticsearch and send them to SNS topic
Apache License 2.0
30 stars 44 forks source link

Improve Alerts with Refine Datapoints on Alerts & Change Period #1

Closed dalvarezquiroga closed 5 years ago

dalvarezquiroga commented 5 years ago

Please review

@dubiety

dubiety commented 5 years ago

@dalvarezquiroga Thanks for the PR, I do notice some of my alarm_description are wrong. For the alarms, I followed the recommendation from AWS document, can you describe more why do you think these modifications are better?

dalvarezquiroga commented 5 years ago

Hi @dubiety , you're right. The AWS recommendations are correct but I need to customize the alerts. For example modifying time, datapoints etc... more specific for the ElasticSearch clusters I have installed.

So I will close the Merge Request, and I will use my fork. Thank you for your answer good module! ;-)