dubiety / terraform-aws-elasticsearch-cloudwatch-sns-alarms

terraform module that configures important alarms for AWS elasticsearch and send them to SNS topic
Apache License 2.0
30 stars 44 forks source link

Feature: Allowing customization of all evaluation periods #18

Closed AndrewFarley closed 2 years ago

AndrewFarley commented 2 years ago

To help decrease the noise of alarms, this parameter needs to be tuned. It was previously added on 2 alarms, I just added the same naming scheme as the 2 previous alarm variables for this, but for all alarms. Please approve/merge and release. Safe confirmed on 3 different terraform stacks with wildly different configurations.

dubiety commented 2 years ago

@AndrewFarley, thank you so much for the PR! I've wanted to support this for a long time. The PR looks good to me!