Reverting #16, adding information and formatting README, adding new alarm for SUM low disk, standardizing variable names

dubiety / terraform-aws-elasticsearch-cloudwatch-sns-alarms

terraform module that configures important alarms for AWS elasticsearch and send them to SNS topic

Apache License 2.0

30 stars 45 forks source link

Closed AndrewFarley closed 2 years ago

AndrewFarley commented 2 years ago

Reverting #16 / #17
Reformatting README's variables, sorting them by relevance and alphabetic order
Standardizing variable names, all bools start with monitor_ and all alarm-related variables start with alarm_
Updating alarm descriptions to include the relevant variables of the alarm (Eg: above % CPU, accurate time periods)
Adding new optional alarm for "aggregate" low disk space, incase someone wants. Set to disabled by default, since this isn't on the "AWS Best-practice alerts for ElasticSearch"

AndrewFarley commented 2 years ago

Reverts #17

AndrewFarley commented 2 years ago

Reverts #16 and implements it differently (via an new alarm)

AndrewFarley commented 2 years ago

@dubiety Looks good to ship dude. :) Cheers!

ericjsilva commented 2 years ago

@AndrewFarley looks like some basic linting issues, but once resolved this looks good to publish.

AndrewFarley commented 2 years ago

@ericjsilva Apologies, linting should be fixed now. Cheers!

AndrewFarley commented 2 years ago

Updated PR and PR description/topic. @dubiety please re-review, lmk if there's any more feedback. Cheers!