Duplicate SNS topics being created

dubiety / terraform-aws-elasticsearch-cloudwatch-sns-alarms

terraform module that configures important alarms for AWS elasticsearch and send them to SNS topic

Apache License 2.0

30 stars 45 forks source link

Closed rajaie-sg closed 2 years ago

rajaie-sg commented 2 years ago

Hi, I noticed that the module creates two SNS topics here https://github.com/dubiety/terraform-aws-elasticsearch-cloudwatch-sns-alarms/blob/master/main.tf#L3-L14 if we create_sns_topic set to true (which is the default). Is there a reason it's doing that? I see both being referenced in the aws_sns_topic_arn local var

dubiety commented 2 years ago

Hi @rajaie-sg ,

Thank you for filing the issue. You're right, there's a logic error here. Will modify it soon.

dubiety commented 2 years ago

The bug should be fix in v3.0.3. Please reopen if you found the problem is still there. Thank you very much.