search

dubiety / terraform-aws-elasticsearch-cloudwatch-sns-alarms

terraform module that configures important alarms for AWS elasticsearch and send them to SNS topic
Apache License 2.0
30 stars 44 forks source link

All alarms example - storage configuration #26

Open ricmano opened 2 years ago

ricmano commented 2 years ago

I was checking the project especially the free storage alarms and when checking all-alarms/main.tf I think line should be updated https://github.com/dubiety/terraform-aws-elasticsearch-cloudwatch-sns-alarms/blob/3ff73343e7af64bde59a6407eeb4ce6b1b98e915/examples/all-alarms/main.tf#L32

to something like this

free storage per node

free_storage_space_threshold = var.elasticsearch_disk_size 1024 0.25

free storage on cluster

free_storage_space_total_threshold = var.elasticsearch_disk_size var.elasticsearch_instance_count 1024 * 0.25

I've also replaced 0.20 with 0.25, in aws documentation we have "we recommend setting it to 25% of the storage space for each node.", this will trigger the alert before having any real problem

Does this make sense? Can I create a pull request with these changes?

dubiety commented 2 years ago

@ricmano I think AWS updated the recommendation. PR is welcome!