SNS topic naming - Githubissues

dubiety / terraform-aws-elasticsearch-cloudwatch-sns-alarms

terraform module that configures important alarms for AWS elasticsearch and send them to SNS topic

Apache License 2.0

30 stars 45 forks source link

Closed msusta closed 4 years ago

msusta commented 4 years ago

What about changing the naming of the SNS alerting topic to utilize the prefix variable (_alarm_nameprefix) instead of the hardcoded value elasticsearch-threshold-alerts? https://github.com/dubiety/terraform-aws-elasticsearch-cloudwatch-sns-alarms/blob/master/main.tf#L10

I generally tend to use multi-tennant and/or multi-service AWS accounts and it's nice to have things prefixed with same thing for easier search.

msusta commented 4 years ago

And BTW thanks for the nice module! :)

dubiety commented 4 years ago

Sorry for the late reply. You're right, it would be better to have a prefix/postfix for the alarm name. I'll make a fix for it.

dubiety commented 4 years ago