search

dubiety / terraform-aws-elasticsearch-cloudwatch-sns-alarms

terraform module that configures important alarms for AWS elasticsearch and send them to SNS topic
Apache License 2.0
30 stars 45 forks source link

Feature: Allow existing SNS via a variable flag #7

Closed AndrewFarley closed 3 years ago

AndrewFarley commented 3 years ago

If anyone has an existing SNS topic, I allowed this module to use that instead of creating one needlessly. The topics created by this module would typically have to then be manually setup with destinations to trigger (email, webhooks, etc), so creating them externally makes a lot of sense (arguably more).

AndrewFarley commented 3 years ago

idk how to run your linter locally, if you can tell me how I can fix linting @dubiety

dubiety commented 3 years ago

@AndrewFarley Thank you so much for the PR. My linting uses terraform fmt to format the code. If it is not formatted, the linting will fail. To check the linting locally, you can run at root folder:

make init
make lint
AndrewFarley commented 3 years ago

@dubiety Thanks, fixed formatting, and confirmed working perfectly, and you can switch back and forth between using an existing SNS topic and not. :P Thanks for the simple but effective module.

If it's not a huge hassle once merged can you please make a release on Terraform Modules, so I can use the public modules and not a local copy? THANKS!

dubiety commented 3 years ago

LGTM. I'll make a new release. Thank you so much.