Hide link destination in Link Inspector

[steven-tey]

From a customer: I want to be able to hide the destination URL from the link inspector.

For instance, I have a form in which I use Dub for gating access (password, time and date, IP geo-location).

[linear[bot]]

ENG-390 Hide link destination in Link Inspector

[UsmanDev09]

I can work on this! @steven-tey

[Pratham271]

@steven-tey are you talking about the highlighted links to be hidden

[kaerez]

The requirement is to add a checkbox for custom domains (free and paying accounts) and for free domains (paying accounts only), which will restrict the destination from being viewable in the inspector (and the inspector DOM).

[Pratham271]

If they are not showing on link inspector then I guess they wouldn't be visible on the DOM inspector except the logo image which will be https://link.com/favicon.ico this is what needs to be hidden in the DOM

[steven-tey]

@Pratham271 I think we need to disable this on the server side for links that are password protected

[Pratham271]

@steven-tey so we have to do it for all password protected links or just for the paid customers and also the checkbox thingy that @kaerez mentioned?

[kaerez]

@Pratham271 I think that password protected links are already blocked. The DOM reference is to ensure the target is also not provided by the backend to the frontend and simply hidden from view. I think we need to add it as a checkbox, as recommended above.

[Pratham271]

@kaerez thanks for the clearance and confirmation. Starting it now

[steven-tey]

@steven-tey so we have to do it for all password protected links or just for the paid customers and also the checkbox thingy that @kaerez mentioned?

I believe only paid customers can create password-protected links atm, so just checking if the link is password protection should be enough!

[kaerez]

Or cloaked

On Mon, Jul 29, 2024 at 08:45, Steven Tey @.***> wrote:
@steven-tey so we have to do it for all password protected links or just for the paid customers and also the checkbox thingy that @kaerez mentioned?

I believe only paid customers can create password-protected links atm, so just checking if the link is password protection should be enough!

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

[Pratham271]

@steven-tey @kaerez is the checkbox fine or should I place it outside the container

[steven-tey]

Actually, just realized that password-protected links are hidden from the link inspector by default.

https://github.com/user-attachments/assets/6f2abcd3-1457-4720-a395-ee8ef6d49e80

Will be closing this issue for now – sorry for the false alarm here guys!

[Pratham271]

But @kaerez suggestion is not yet implemented that user can specify some links to be hidden from the dom inspector