Support generic action/deep link formats

dubinc / dub

Open-source link management infrastructure. Loved by modern marketing teams like Vercel, Raycast, and Perplexity.

https://dub.co

GNU Affero General Public License v3.0

17.49k stars 1.83k forks source link

Support generic action/deep link formats #1077

Open kaerez opened 1 month ago

kaerez commented 1 month ago

Support the regex below, which supports other valid links such as: sms:+12125551212 call:2125551212 whatsapp://send com.acme.a1t-3://license?set=1f6R@!a

Applicable regex: ([\S]+\:[\S]+)

linear[bot] commented 1 month ago

ENG-444 Support generic action/deep link formats

steven-tey commented 1 month ago

We do have the isSupportedDeepLinkProtocol check which supports most of the examples here, but we're wary of opening it up to a generic regex in case of abuse. Any thoughts/advice here?

kaerez commented 1 month ago

Deeplinks are officially supported in RFC's and by Google and Apple. Any HTML can have a meta redirect, shadow (reporting) link, direct href link, etc... I think, at least for custom domains, this should be permitted. This could also be an opportunity to possibly support adding a permissive and/or restrictive regex to the ui for admins.